Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tcptraceroute: init at 1.5beta7 #25943

Merged
merged 1 commit into from
May 20, 2017
Merged

tcptraceroute: init at 1.5beta7 #25943

merged 1 commit into from
May 20, 2017

Conversation

pbogdan
Copy link
Member

@pbogdan pbogdan commented May 20, 2017

Motivation for this change

Make tcptraceroute available in nixpkgs.

Notes:

  • I'm unsure on version names with suffixes such as beta7. Is it fine as is or would 1.5-beta7 be more appropriate, or perhaps some other variation?
  • I don't particularly like the CFLAGS hack but no matter what configure flags I try I can't disable static linking. Neither --disable-static nor --enable-static=no appears to work although I haven't looked into this further.
Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Mic92 Mic92 merged commit 9197876 into NixOS:master May 20, 2017
@Mic92
Copy link
Member

Mic92 commented May 20, 2017

Thanks!

@pbogdan pbogdan deleted the tcptraceroute branch December 3, 2019 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants