Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hunskell: add basque dictionary Xuxen 5 #25944

Merged
merged 1 commit into from
May 20, 2017
Merged

Conversation

umazalakain
Copy link
Contributor

@umazalakain umazalakain commented May 20, 2017

mkDict doesn't easily adapt to dictionaries that have multiple source
files but no readme, so I did not use it. Having a "generic" function
that then has per-language quirks is a bad abstraction.

A small utility function that copies a given file to hunspell's and
myspell's dirs and a separate one that copies a given readme file would
be more useful.

Motivation for this change

I want to have a spellchecker that understands me.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

mkDict doesn't easily adapt to dictionaries that have multiple source
files but no readme, so I did not use it. Having a "generic" function
that then has per-language quirks is a bad abstraction.

A small utility function that copies a given file to hunspell's and
myspell's dirs and a separate one that copies a given readme file would
be more useful.
@Mic92 Mic92 merged commit b2a14ee into NixOS:master May 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants