Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

st: extraLibs argument #25956

Closed
wants to merge 2 commits into from
Closed

st: extraLibs argument #25956

wants to merge 2 commits into from
+3 −2

Conversation

adrianparvino
Copy link
Contributor

@adrianparvino adrianparvino commented May 21, 2017 •
edited
Loading

Motivation for this change

Being able to add extra libraries would greatly benefit paches.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@Mic92
Copy link
Member

Mic92 commented May 21, 2017 •
edited
Loading

Please do not use git merge or plain git pull in a pull request. If you want to update your branch, use git pull --rebase or git rebase. This makes it easier to review code, when checking out the source code.

@Mic92 Mic92 closed this in 7d97051 May 21, 2017
@Janik-Haag Janik-Haag added the 12. first-time contribution This PR is the author's first one; please be gentle! label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@adrianparvino @Mic92 @Janik-Haag