LB-155: Make Redis connection establishment more reliable #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do a ping and if ConnectionErrors are thrown, sleep for two seconds and try to establish a new connection.
paramsingh
changed the title
|
Doing a ping because Fixed the connection establishment for
The last two had the loops already but didn't ping the server, so only needed to add a ping. :) |
|
Does it make sense to quit after some number of connection attempts (say, 5?) instead of continually trying to connect and failing? |
|
The whole point is to keep trying -- containers may come up and down at any point. Waiting nicely and retrying allows the system to self heal, without having to restart containers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do a ping and if ConnectionErrors are thrown, sleep for two
seconds and try to establish a new connection.