Fix IO::Memory#gets_to_end to consume the IO

crystal-lang · May 20, 2017 · b2def93 · b2def93
1 parent 6dffcff
commit b2def93
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/spec/std/io/memory_spec.cr b/spec/std/io/memory_spec.cr
@@ -331,6 +331,12 @@ describe IO::Memory do
     end
   end
 
+  it "consumes with gets_to_end" do
+    io = IO::Memory.new("hello world")
+    io.gets_to_end.should eq("hello world")
+    io.gets_to_end.should eq("")
+  end
+
   it "peeks" do
     str = "hello world"
     io = IO::Memory.new(str)

diff --git a/src/io/memory.cr b/src/io/memory.cr
@@ -225,7 +225,9 @@ class IO::Memory
     if pos == @bytesize
       ""
     else
-      String.new(@buffer + @pos, @bytesize - @pos)
+      String.new(@buffer + @pos, @bytesize - @pos).tap {
+        @pos = @bytesize
+      }
     end
   end