Patch/interfaces #325
Merged
Patch/interfaces #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ly interfaces they appear in the method signature.
…dentally renamed by IDE).
|
Sorry I mean: DefaultChemObjectReader etc.. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves interfaces in the IO/IOFormats modules down to cdk-interfaces. Some small classes (e.g exceptions) have to follow to.
Q: I would like to think of the cdk-interfaces module more like 'cdk-api' which is the core public API and does not limit it's contents to just interfaces. For example I would also like to push SimpleChemObjectReader/Writer down to the interfaces, this would allow me to split out the MDL format reading into a 'cdk-ctab' module and would make things very cleaner in the cdk-io which is a bit of rag bag of functionality ATM.
@egonw Your thoughts on moving SimpleChemObjectReader/Writer down to cdk-interfaces?