Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rodjek/vim-puppet: init #25965

Merged
merged 1 commit into from
May 21, 2017
Merged

rodjek/vim-puppet: init #25965

merged 1 commit into from
May 21, 2017

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented May 21, 2017

Motivation for this change

vim-puppet is a helpful plugin which is needed to get syntax highlighting for Puppet.

I generated the vim-nix expressions as described here:

# Regenerate via `nix-build -Q -A vimPlugins.pluginnames2nix; ./result/bin/vim-plugin-names-to-nix`

After that I confirmed the build by running the following command:

nix-build -A vimPlugins
Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature. The key has expired.
panzarino Zach Panzarino
@mention-bot
Copy link

@Ma27, thanks for your PR! By analyzing the history of the files in this pull request, we identified @jagajaga, @Mic92 and @LnL7 to be potential reviewers.

@jagajaga jagajaga merged commit 5e9430a into NixOS:master May 21, 2017
@Ma27 Ma27 deleted the new-vim-plugin/vim-puppet branch May 21, 2017 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants