znapzend service: Added options for logging and nodestroy #25960
Conversation
|
@infinisil, thanks for your PR! By analyzing the history of the files in this pull request, we identified @otwieracz, @Mic92 and @dermetfan to be potential reviewers. |
|
|
||
| logTo = mkOption { | ||
| type = types.str; | ||
| default = ""; |
There was a problem hiding this comment.
$ znapzend --logto=
Option logto requires an argument
This option should have a sensible default or appended optianlly like noDestroy.
There was a problem hiding this comment.
Thanks, I added znapzends default.
| ExecReload = "${pkgs.coreutils}/bin/kill -HUP $MAINPID"; | ||
| #Restart = "on-failure"; |
There was a problem hiding this comment.
Accident, fixed in the next commit
| @@ -26,7 +26,7 @@ in | |||
|
|
|||
| noDestroy = mkOption { | |||
| type = types.bool; | |||
| default = true; | |||
| default = false; | |||
There was a problem hiding this comment.
Default for noDestroy should be false, not true
|
I wanna apologize for the many small changes after opening the PR, I'm still kind of new to git, github and nix, I'll test my changes better next time :) |
|
No problem there. Thanks for your contributions! 🍻 LGTM now. 👍 Let's wait a bit for @Mic92 for a quick review. |
|
Oh, and if you want you can try to squash your commits into one, i.e. with |
|
Thanks! |
and service now restarts on failure
Motivation for this change
The znapzend program has some useful options that weren't accessible before.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)