Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fcitx service: add QT_PLUGIN_PATH to env #25951

Closed
wants to merge 1 commit into from

Conversation

ericsagnes
Copy link
Contributor

PR #25285 removed the auto-detection of qt plugins from NIX_PROFILE,
explicitly declaring QT_PLUGIN_PATH in the module solve the problem

Motivation for this change
Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

PR NixOS#25285 removed the auto-detection of qt plugins from NIX_PROFILE,
explicitly declaring QT_PLUGIN_PATH in the module solve the problem
GTK_IM_MODULE = "fcitx";
QT_IM_MODULE = "fcitx";
XMODIFIERS = "@im=fcitx";
QT_PLUGIN_PATH = "${fcitxPackage}/lib/qt5/plugins";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this environment variable never get overridden by someone else?

$ echo $QT_PLUGIN_PATH
/etc/per-user-pkgs/joerg/lib/qt4/plugins:/etc/per-user-pkgs/joerg/lib/kde4/plugins:/home/joerg/.nix-profile/lib/qt4/plugins:/home/joerg/.nix-profile/lib/kde4/plugins:/nix/var/nix/profiles/default/lib/qt4/plugins:/nix/var/nix/profiles/default/lib/kde4/plugins:/run/current-system/sw/lib/qt4/plugins:/run/current-system/sw/lib/kde4/plugins

@bjornfor
Copy link
Contributor

I think the part of #25285 that removed looking in $NIX_PROFILE got reverted. CC @ttuegel.

@ericsagnes
Copy link
Contributor Author

@bjornfor Nice catch, got confused with the unusual delay between master and unstable.
Closing this as this should not be needed anymore.

@ericsagnes ericsagnes closed this May 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants