LINT fix & check all files with clang-format

nerzhul · nerzhul · commit 05309229b847 · 2017-05-22T07:28:35.000+02:00
Seems the diff mode doesn't work well, PR are detected as working whereas in master it's shown it's problematic (and really problematic). Use same check everywhere
diff --git a/src/script/lua_api/l_client.cpp b/src/script/lua_api/l_client.cpp
@@ -88,7 +88,7 @@ int ModApiClient::l_display_chat_message(lua_State *L)
 // send_chat_message(message)
 int ModApiClient::l_send_chat_message(lua_State *L)
 {
-	if (!lua_isstring(L,1))
+	if (!lua_isstring(L, 1))
 		return 0;
 	std::string message = luaL_checkstring(L, 1);
 	getClient(L)->sendChatMessage(utf8_to_wide(message));
diff --git a/util/travis/lint.sh b/util/travis/lint.sh
@@ -9,13 +9,7 @@ function perform_lint() {
 	echo "LINT: Using binary $CLANG_FORMAT"
 	CLANG_FORMAT_WHITELIST="util/travis/clang-format-whitelist.txt"
 
-	if [ "$TRAVIS_EVENT_TYPE" = "pull_request" ]; then
-		# Get list of every file modified in this pull request
-		files_to_lint="$(git diff --name-only --diff-filter=ACMRTUXB $TRAVIS_COMMIT_RANGE | grep '^src/[^.]*[.]\(cpp\|h\)$' | true)"
-	else
-		# Check everything for branch pushes
-		files_to_lint="$(find src/ -name '*.cpp' -or -name '*.h')"
-	fi
+	files_to_lint="$(find src/ -name '*.cpp' -or -name '*.h')"
 
 	local errorcount=0
 	local fail=0

Original file line number	Diff line number	Diff line change
`@@ -88,7 +88,7 @@ int ModApiClient::l_display_chat_message(lua_State *L)`
`88`	`88`	`// send_chat_message(message)`
`89`	`89`	`int ModApiClient::l_send_chat_message(lua_State *L)`
`90`	`90`	`{`
`91`		`- if (!lua_isstring(L,1))`
	`91`	`+ if (!lua_isstring(L, 1))`
`92`	`92`	`return 0;`
`93`	`93`	`std::string message = luaL_checkstring(L, 1);`
`94`	`94`	`getClient(L)->sendChatMessage(utf8_to_wide(message));`