Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allowing for certain configuration macros being defined conditionally #2646

Merged
merged 1 commit into from May 25, 2017
Merged

Allowing for certain configuration macros being defined conditionally #2646

merged 1 commit into from May 25, 2017

Conversation

hkaiser
Copy link
Member

@hkaiser hkaiser commented May 21, 2017

No description provided.

@hkaiser hkaiser added this to the 1.1.0 milestone May 21, 2017
@hkaiser hkaiser force-pushed the fixing_config_definitions branch from 684a0d9 to 7a84d2b Compare May 21, 2017 21:37
@hkaiser hkaiser force-pushed the fixing_config_definitions branch from 7a84d2b to a99b21b Compare May 22, 2017 16:23
sithhell
sithhell approved these changes May 23, 2017
View reviewed changes
Copy link
Member

@sithhell sithhell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from the cmake side ...

@hkaiser hkaiser merged commit 96c8a4c into master May 25, 2017
@hkaiser hkaiser deleted the fixing_config_definitions branch May 25, 2017 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sithhell sithhell sithhell approved these changes

Assignees
No one assigned
Labels
category: CMake type: enhancement
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hkaiser @sithhell