libopus: 1.1.3 -> 1.1.4 #25973
Merged
libopus: 1.1.3 -> 1.1.4 #25973
+2
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@GeNTooFReaK, thanks for your PR! By analyzing the history of the files in this pull request, we identified @viric, @vcunat and @fpletz to be potential reviewers. |
Mic92
added
the
1.severity: security
|
Tested and successfully built some packages depending on libopus. Thanks! |
fpletz
pushed a commit
that referenced
this pull request
May 22, 2017
(cherry picked from commit 88af502) Security release. See #25973. Fixes CVE-2017-0381.
ghost
deleted the
|
Well, that CVE was patched, so this PR seems basically a no-op... |
vcunat
removed
the
1.severity: security
adrianpk
added a commit
to adrianpk/nixpkgs
that referenced
this pull request
May 31, 2024
(cherry picked from commit 88af502) Security release. See NixOS#25973. Fixes CVE-2017-0381.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
http://opus-codec.org/release/stable/2017/01/20/libopus-1_1_4.html
This Opus 1.1.4 release fixes a single bug. A specially-crafted Opus packet could cause an integer wrap-around in the SILK LSF stabilization code. This would cause an out-of-bounds read 256 bytes before a constant table. In most circumstances, the consequences are harmless and the result is simply noise in the audio.
This was reported as CVE-2017-0381. Contrary to that report, our own analysis shows that no remote code execution is possible. However, we are making this release as a precaution.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)