Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cython: build on 32-bit ARM #25981

Merged
merged 1 commit into from
May 22, 2017
Merged

cython: build on 32-bit ARM #25981

merged 1 commit into from
May 22, 2017

Conversation

rimmington
Copy link
Contributor

Motivation for this change

Gets Cython working on a Raspberry Pi.

It would be great if this could be cherry-picked onto 17.03. I'm not sure what the procedure is for 17.03 changes.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@rimmington, thanks for your PR! By analyzing the history of the files in this pull request, we identified @FRidh to be a potential reviewer.

@matthewbauer
Copy link
Member

Maybe just applying this patch works as well:

https://github.com/cython/cython/commit/d92a718a26c9354fbf35f31a17de5c069865a447.patch

It should be included in the next release.

@FRidh FRidh merged commit 64a924a into NixOS:master May 22, 2017
@FRidh
Copy link
Member

FRidh commented May 22, 2017

pushed to 17.03 as well 9fd6417

@rimmington rimmington deleted the cython-arm-pr branch May 22, 2017 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants