Introduce a more-minimal base theme. #120
Conversation
| </nav> | ||
| </%def> | ||
|
|
||
| <%def name="html_translation_header()"> |
There was a problem hiding this comment.
What’s wrong with keeping it in base_helper.tmpl under the old name?
| @@ -0,0 +1,10 @@ | |||
| ## -*- coding: utf-8 -*- | |||
There was a problem hiding this comment.
What did you change here? Avoid duplicating templates if you only delete the namespace (which I agree is unnecessary, perhaps we should to that upstream)
| else: | ||
| atom_ref = kind + '_atom' | ||
| rss_ref = kind + '_rss' | ||
| label = ' for ' + kind + ' ' + name |
There was a problem hiding this comment.
Hm. I’d really like to see something like this upstream, but with i18n support, optional JSONFeed support, and without a raw Python block (which are not allowed in Jinja2) — changes to the core codebase to allow this everywhere would be more welcome.
| @@ -0,0 +1,19 @@ | |||
| ## -*- coding: utf-8 -*- | |||
There was a problem hiding this comment.
I would keep that mathjax_script helper and not change this template. Perhaps some people want to switch from base to base-austere, and they will get unusual errors about missing things.
| @@ -0,0 +1 @@ | |||
| <%inherit file="story.tmpl"/> | |||
There was a problem hiding this comment.
Delete this file due to no changes.
| @@ -0,0 +1,330 @@ | |||
| /* | |||
There was a problem hiding this comment.
No need to duplicate this file if you inherit from base.
| ${comments.comment_form(post.permalink(absolute=True), post.title(), post._base_path)} | ||
| </section> | ||
| % endif | ||
| ${math.math_scripts_ifpost(post)} |
There was a problem hiding this comment.
I had to make a diff and I found out we had a bug in base (scripts vs styles). I fixed that in getnikola/nikola@d9ee04f4, but it’d be great if you would also make changes to the built-in base theme.
(That file is unnecessary after that fix.)
|
In /* reset inner alignment in figures */
-.figure.align-right {
+div.align-right {
text-align: inherit }Why? |
| <meta name="twitter:creator" content="${twitter_card['creator']}"> | ||
| %endif | ||
| %endif | ||
| </%def> |
There was a problem hiding this comment.
Restore mathjax_script as well.
|
Maybe I'll try to cut a PR against upstream for the structural changes and then see what's left. |
|
What’s the status of this? Do we really need this? |
|
I think enough stuff got pared down in my rework of the base theme that this can be closed out. |
This is a somewhat more austere base theme, meant to provide details for the discussion in getnikola/nikola#2744