Spec description grammer [docs] #4444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RX14
requested changes
May 22, 2017
src/spec.cr
Outdated
| # | ||
| # Concrete test cases are defined with `it` within a `describe` block. A | ||
| # descriptive string is supplied to `it` describing what that test case | ||
| # Within a `describe` block concrete test cases are defined with `it` . A |
| # tests specifically. | ||
| # | ||
| # Specs then use the `should` method to verify that the expected value is | ||
| # returned, see the example above for details. |
There was a problem hiding this comment.
I'm not 100% on this change, maybe move the full stop before the brackets?
|
Thanks for suggestions 👍 |
|
This is great! Thank you @mjago ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small changes to improve spec doc description