@shosti, thanks for your PR! By analyzing the history of the files in this pull request, we identified @peterhoeg and @aflatter to be potential reviewers.

Doesn't yarn install need to access the internet to download dependencies?

Yes I think so, didn't realize that isn't allowed. So yarn install isn't kosher?

(I tried npm2nix but it doesn't seem to work with Node 7 yet...)

@shosti take a look at node2nix. You probably can add your package to ./pkgs/development/node-packages.

node2nix doesn't currently work for this because heroku has a hard dependency on node 7, and node2nix only makes nix files for node <= 6. Maybe this should wait until node2nix gets updated?

@shosti It looks like there has recently been some commits on node2nix that give it a -7 flag which I assume allows node 7 packages. Worth a shot?

If somebody is in hurry and needs heroku quickly:

# bashrc/zshrc
heroku(){
  docker run -it --rm -u $(id -u):$(id -g) -w "$HOME" \
    -v /etc/passwd:/etc/passwd:ro \
    -v /etc/group:/etc/group:ro \
    -v /etc/localtime:/etc/localtime:ro \
    -v /home:/home \
    -v /tmp:/tmp \
    -v /run/user/$(id -u):/run/user/$(id -u) \
    -v $(pwd):/workdir \
    -w /workdir \
    --name heroku \
    johnnagro/heroku-toolbelt "$@"
}

@Mic92 Thank you very much for your addition! I found that it couldn't interact with the local directory such as is necessary when running create and the like, so I added two extra lines to fix this:

-v $(pwd):/workdir \
-w /workdir \

The first adds the working directory as a volume, and the second makes that directory the WORKDIR.

@shosti bump? It sounds like the node2nix issue isn't blocking since your PR adding node 7 support was merged in. Do you know if there are any other blocking issues?

The current heroku package is marked broken. Is this the only PR that makes heroku work again?

@CMCDragonkai i think we need to package this with node2nix.

/me runs node2nix

Yeah sorry I haven’t had time to get this working. node2nix seems to get the dependencies ok, but I haven’t figured out how to get the binaries wrapped properly. If someone wants to take this over that would be awesome.

It looks like mkYarnPackage may be the easiest way to go.

As a workaround until this gets finished, here's how I got heroku cli installed on NixOS 18.03

git clone https://github.com/heroku/cli.git heroku-cli
cd heroku-cli
nix-env -f '<nixpkgs>' -iA nodePackages.node2nix
node2nix -8
nix-build -A package
nix-env -i ./result
heroku login

I've opened #42869 as the next attempt at fixing this, I'm going to close this issue as it's outdated.