Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: mockingbirdnest/Principia
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: b210810bb41b
Choose a base ref
...
head repository: mockingbirdnest/Principia
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 24a7998a6a09
Choose a head ref
  • 2 commits
  • 1 file changed
  • 1 contributor

Commits on May 21, 2017

  1. No space after commas in CSV.

    pleroy committed May 21, 2017

    Verified

    This commit was signed with the committer’s verified signature. The key has expired.
    marsam Mario Rodas
    Copy the full SHA
    c82be17 View commit details
  2. Merge pull request #1394 from pleroy/Coverage

    No space after commas in CSV
    pleroy authored May 21, 2017

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    24a7998 View commit details
Showing with 7 additions and 7 deletions.
  1. +7 −7 coverage_analyser/coverage_analyser.cs
14 changes: 7 additions & 7 deletions coverage_analyser/coverage_analyser.cs
Original file line number Diff line number Diff line change
@@ -134,15 +134,15 @@ private static void Main(string[] args) {
File.WriteAllText(
Path.Combine(coverage_file.Directory.FullName,
"jenkins_percent_coverage.csv"),
"not covered, partially covered, fully covered\n" +
((double)lines_not_covered / (double)total) * 100.0 + ", " +
((double)lines_partially_covered / (double)total) * 100.0 + ", " +
"not covered,partially covered,fully covered\n" +
((double)lines_not_covered / (double)total) * 100.0 + "," +
((double)lines_partially_covered / (double)total) * 100.0 + "," +
((double)lines_covered / (double)total) * 100.0);
File.WriteAllText(Path.Combine(coverage_file.Directory.FullName,
"jenkins_lines_coverage.csv"),
"not covered, partially covered, fully covered\n" +
lines_not_covered + ", " + lines_partially_covered +
", " + lines_covered);
"not covered,partially covered,fully covered\n" +
lines_not_covered + "," + lines_partially_covered +
"," + lines_covered);
File.WriteAllText(Path.Combine(coverage_file.Directory.FullName,
"jenkins_lines_coverage_breakdown.csv"),
unit_names + "\n" + breakdown_lines_not_covered);
@@ -161,7 +161,7 @@ private static void CommaSeparatedAppend(ref string csv, string value) {
if (csv == "") {
csv = value;
} else {
csv = csv + ", " + value;
csv = csv + "," + value;
}
}
}