Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.thefuck: init at 3.18 #26529

Merged
merged 1 commit into from
Jun 14, 2017
Merged

pythonPackages.thefuck: init at 3.18 #26529

merged 1 commit into from
Jun 14, 2017

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Jun 12, 2017

Motivation for this change

This tool (https://github.com/nvbn/thefuck) is highly needed to increase my productivity on mondays like this.

I created a module which automatically builds the alias thefuck --alias needed for the actual setup and a python package to build thefuck.

I tested the change using the following configuration:

{
  fuck = { pkgs, lib, ... }: with lib; {
    programs.thefuck.enable = true;

    users.extraUsers.test = {
      password = "123456";
      extraGroups = [ "wheel" ];
      isNormalUser = true;
      shell = "/run/current-system/sw/bin/zsh";
    };

    # used to confirm that it works with `zsh` as well
    programs.zsh.enable = true;
  };
}

Command to bootstrap the VM:

NIX_PATH=nixpkgs=$HOME/Projects/nixpkgs/ nixos-build-vms vmtest.nix
Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@@ -30374,6 +30374,31 @@ EOF
};
};

thefuck = buildPythonPackage rec {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As this is a regular program/tool, this shouldn't be in pythonPackages. Just pu it in all-packages.nix and for example pkgs/tools/misc. :)

@Ma27
Copy link
Member Author

Ma27 commented Jun 13, 2017

@fpletz I fixed the problem. However please keep in mind that I will be on vacation for the next 10 days, so any further changes might be applied with a certain delay :-)

@Mic92 Mic92 merged commit 3803864 into NixOS:master Jun 14, 2017
@Ma27 Ma27 deleted the new-package/thefuck branch June 24, 2017 08:38
therealpxc pushed a commit to therealpxc/nixpkgs that referenced this pull request Aug 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants