arduino: 1.6.12 -> 1.8.2 #26294
Closed
arduino: 1.6.12 -> 1.8.2 #26294
+94
−62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Applied to master (758864a). Thanks! |
Janik-Haag
added
the
12. first-time contribution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
1.6.12 is no longer supported by the Arduino developers.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)Noteworthy changes
While making this update, I made a typo in a filename in downloads.nix, and Arduino's
build.xmldownloaded the correct file itself. In order to make sure all sources are downloaded through Nix, I added a simple patch that breaksbuild.xml's download functionality.I also did some investigating to try to find a way to install the Teensyduino version by some method other than running a graphical installer with
xdotool. But what I discovered is that the graphical installer is a closed-source binary which adds more closed-source binary executables to Arduino (not just firmware). So I changed its license to unfree, and the download method (of everything) from http to https.