Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

arduino: 1.6.12 -> 1.8.2 #26294

Closed
wants to merge 1 commit into from
Closed

Conversation

gazally
Copy link
Contributor

@gazally gazally commented Jun 1, 2017

Motivation for this change

1.6.12 is no longer supported by the Arduino developers.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.
Noteworthy changes

While making this update, I made a typo in a filename in downloads.nix, and Arduino's build.xml downloaded the correct file itself. In order to make sure all sources are downloaded through Nix, I added a simple patch that breaks build.xml's download functionality.

I also did some investigating to try to find a way to install the Teensyduino version by some method other than running a graphical installer with xdotool. But what I discovered is that the graphical installer is a closed-source binary which adds more closed-source binary executables to Arduino (not just firmware). So I changed its license to unfree, and the download method (of everything) from http to https.

@mention-bot
Copy link

@gazally, thanks for your PR! By analyzing the history of the files in this pull request, we identified @binarin, @cko and @bjornfor to be potential reviewers.

@bjornfor
Copy link
Contributor

bjornfor commented Jun 1, 2017

Applied to master (758864a). Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants