Skip to content

uwsgi: fix php plugin build #26290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 2, 2017
Merged

uwsgi: fix php plugin build #26290

merged 1 commit into from
Jun 2, 2017
+1 −1

Conversation

bachp
Copy link
Member

@bachp bachp commented May 31, 2017

Motivation for this change

Currently the build of uwsgi with the php plugin fails as the dependencies are missing and the linker can not find them.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@bachp
Copy link
Member Author

bachp commented Jun 1, 2017

@schneefux @abbradar I think you two are the maintainers

@abbradar
Copy link
Member

abbradar commented Jun 2, 2017

I think the correct way would be: [ php-embed ] ++ php-embed.nativeBuildInputs. Can you test this out? As it is you are passing a nested list.

@bachp
Copy link
Member Author

bachp commented Jun 2, 2017

@abbradar Unfortunatly inputs = [ php-embed ] ++ php-embed.nativeBuildInputs; still gives the same error as before.

inputs = [ php-embed ] ++ php-embed.buildInputs; works and it even leads to the exact same hash as inputs = [ php-embed php-embed.buildInputs ];

@abbradar
Copy link
Member

abbradar commented Jun 2, 2017

@backp Oh, sorry, I meant exactly buildInputs. Fixup the commit then and we are good to go!

@bachp
Copy link
Member Author

bachp commented Jun 2, 2017

@abbradar fixup done

@abbradar abbradar merged commit e37f970 into NixOS:master Jun 2, 2017
@abbradar
Copy link
Member

abbradar commented Jun 2, 2017

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bachp @abbradar