Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RealEngines v1.6 RO support #1661

Merged
merged 3 commits into from Jun 1, 2017
Merged

RealEngines v1.6 RO support #1661

merged 3 commits into from Jun 1, 2017

Conversation

PhineasFreak
Copy link
Contributor

Change Log:

  • Add RO support for the new SuperDraco engine.

Notes:

@SirKeplan SirKeplan merged commit 7ed2ffe into KSP-RO:master Jun 1, 2017
@PhineasFreak PhineasFreak deleted the RO-RealEngines-1.6 branch June 2, 2017 06:52
@pap1723
Copy link
Contributor

pap1723 commented Jun 7, 2017

@PhineasFreak I believe that you did the configs for RealEngines (I could be wrong) and I havne't used them yet, but @leudaimon has reported that the RD-108 does not have roll support with it's vernier engines.

The CFG for RealEngines looks different from the one for SXT and the information for gimbal is put directly into the RealEngines file. Now, I do not know enough about CFG files to know if this is affecting the results of @leudaimon but I wanted to check with you.

This is in the config for RealEngines RD108:

@PART[RD108]:AFTER[RealismOverhaulEngines]    
{
    @MODULE[ModuleGimbal]:HAS[#gimbalTransformName[gimbal2]]
    {
        @gimbalRangeYP = 0
        @gimbalRangeYN = 0
        @gimbalRangeXP = 45.0
        @gimbalRangeXN = 45.0
        @gimbalResponseSpeed = 16
    }
}

While the config for the SXT version is just using the Engine_Config to get the desired gimbal.
Here is the Engine_Config gimbal information:

@MODULE[ModuleGimbal]
{
    %gimbalRange = 4.5
    %useGimbalResponseSpeed = True
    %gimbalResponseSpeed = 16
}

@PhineasFreak
Copy link
Contributor Author

@pap1723 For the first part of the question: yes, i did all the configs for the RealEngines. The problem with the RD-108 is in it's model and not the RO config: the vernier transforms are incorrectly set, meaning that they are actually moving in different directions (instead of rolling). Do a quick test: load the engine mounted on a filled tank and launch clamps and fire it without decoupling it. Then try to do a roll maneuver. You will see that the vernier plumes are all moving inwards or outwards instead of rolling. That is a job for Alcentar to fix and IIRC i have reported it to him.

For the second part: the global engine config for the RD-107 and RD-108 engines assumes that the engine does not have integrated verniers. So, we set the gimbal module to affect the main engine module (instead of the non-existent verniers) otherwise you would not have any thrust vectoring control. The gimbal range is scaled down, since to match the same force from the thrust vectoring of the main engine (972 / 918 kN @ 4.5 degrees) to the force of the verniers (4 x 38 kN @ 45 degrees) you need less of it.

The SXT RD-107/108 engines are also not "real" RD-107/108 engines. The RealEngines pack, that includes separate verniers, require special handling (patches) to achieve the same results, as presented in the RO configs.

@pap1723
Copy link
Contributor

pap1723 commented Jun 7, 2017

I knew you would have a detailed response and valid reasons for all that you did! So the roll function will stay broken until it is correctly fixed by RealEngines on their end?

@PhineasFreak
Copy link
Contributor Author

Unfortunately yes. I am hoping that it will be fixed for the next RealEngines release as it does not seem as a difficult thing (compared to making new engine models).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants