Skip to content

python.pkgs.txaio: fix tests under python 3.6 #26288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 31, 2017
Merged

python.pkgs.txaio: fix tests under python 3.6 #26288

merged 1 commit into from
May 31, 2017
+3 −1

Conversation

risicle
Copy link
Contributor

@risicle risicle commented May 31, 2017

Consists of disabling the failing test because it is removed upstream.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@risicle
python.pkgs.txaio: disable test_chained_callback test as it is remove…
0d6eb35 
…d upstream

because it breaks under python3.6
@mention-bot
Copy link

@risicle, thanks for your PR! By analyzing the history of the files in this pull request, we identified @nand0p, @lsix and @FRidh to be potential reviewers.

@Mic92 Mic92 merged commit a0a6187 into NixOS:master May 31, 2017
@risicle risicle deleted the txaio-test-fix branch June 1, 2017 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@risicle @mention-bot @Mic92