Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SuperDraco global engine config updates #1660

Merged
merged 3 commits into from Jun 1, 2017
Merged

SuperDraco global engine config updates #1660

merged 3 commits into from Jun 1, 2017

Conversation

PhineasFreak
Copy link
Contributor

Change Log:

  • Add an extra web source.
  • Add a default part config category.
  • Add some default ModuleEngines patching.
  • Make sure that no gimbal or alternator modules exist in the part config.
  • Make sure that no resources exist in the part config.
  • Add a basic TF config.

Notes:

@PhineasFreak PhineasFreak mentioned this pull request May 31, 2017
Merged
SirKeplan
SirKeplan requested changes May 31, 2017
View reviewed changes
GameData/RealismOverhaul/Engine_Configs/SuperDraco_Config.cfg Outdated
@MODULE[ModuleEngines*]
{
@minThrust = 14.59
@maxThrust = 72.95
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was set to 85kN because that is the vac thrust, 72kN is sea level thrust as stated in the .pdf

GameData/RealismOverhaul/Engine_Configs/SuperDraco_Config.cfg Outdated
minThrust = 17.1
maxThrust = 85.5
minThrust = 14.59
maxThrust = 72.95
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as above

GameData/RealismOverhaul/Engine_Configs/SuperDraco_Config.cfg
key = 0 280.10 //this appears to be a guess
key = 1 239.80
key = 0 280 // This is a complete guess.
key = 1 240
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense, seems to be false precision we had here before.

@PhineasFreak
Copy link
Contributor Author

Sometimes i really need someone to slap me in the face for missing the obvious things...

@SirKeplan SirKeplan merged commit 1644630 into KSP-RO:master Jun 1, 2017
@PhineasFreak PhineasFreak deleted the RO-SuperDraco-Global-Config-Updates branch June 2, 2017 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SirKeplan SirKeplan SirKeplan requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@PhineasFreak @SirKeplan