Introduce Math.frexp method. #4560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PS: It may be used by Float64.hash (to solve crystal-lang#3932).
|
@Sija It's a bug because of LLVM 3.5 |
|
@asterite |
|
Ah, well. Then there's something wrong with how we are using LLVM but unfortunately I have no idea why. Probably something gets disposed and still being used. |
|
Doesn't mean the compiler was compiled using LLVM 3.8 @Sija. |
|
@RX14 Ah, that's probably it. At least on my machine, where I have the compiler compiled with 4.0, I never got that error. In any case it's a minor issue because it only affects the compiler, randomly, but not the executables produced by the compiler. |
|
@asterite Compiler works fine on LLVM 3.9 and 4.0. Looks like it failed or earlier LLVMs. |
akzhan
added a commit
to akzhan/crystal
that referenced
this pull request
Jul 1, 2017
akzhan
added a commit
to akzhan/crystal
that referenced
this pull request
Aug 4, 2017
RX14
pushed a commit
that referenced
this pull request
Sep 1, 2017
* Additions to Big arithmetics. Follows #4560. * Follow @RX14 review (single line blocks, extract mantissa bits constants). * Int cast is implicit here. * Format src/big/big_rational.cr * BigRational is not float, and frexp should be not used on it. * frexp should not be used on BigInt. * rework BigFloat./ * rename bsi, bfsi, bsf, bfsf etc. in spec. * rework def BigFloat.<=>(other : Int) * Simplify a bit, thanks to @RX14 * just remove commen. looks like single Number constructor looks OK in every case. * more verbose naming for used variables. * just explanation of workaround, refs #4897 * For now overloads work (i don't know why). * dedup * Forward declarations of Big Arithmentics types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PS: It may be used by Float64.hash (to solve #3932).