loadlibrary: init at 2551be #26074
Merged
loadlibrary: init at 2551be #26074
+35
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
proteansec
force-pushed
the
pkgs/loadlibrary
branch
from
e621d4a to
2551bef
Compare
| { fetchurl, cabextract, glibc_multi, fetchFromGitHub, readline, stdenv_32bit }: | ||
|
|
||
| stdenv_32bit.mkDerivation { | ||
| name = "loadlibrary"; |
There was a problem hiding this comment.
version is missing, use something like this:
name = "loadlibrary-${version}";
version = "20170525-${lib.strings.substring 0 7 rev}";
rev = "ca6dce8719d4fd0d347c218cb844275518261bf1";
src = fetchFromGitHub {
inherit rev;
owner = "taviso";
repo = "loadlibrary";
sha256 = "01hb7wzfh1s5b8cvmrmr1gqknpq5zpzj9prq3wrpsgg129jpsjkb";
};
The same we use for go packages.
There was a problem hiding this comment.
Date of commit is used, so nix knows when to update package.
| meta = with stdenv_32bit.lib; { | ||
| homepage = "https://github.com/taviso/loadlibrary"; | ||
| description = "Porting Windows Dynamic Link Libraries to Linux"; | ||
| platforms = platforms.unix; |
There was a problem hiding this comment.
Unix means also osx, are you sure? You can also use platforms.linux.
|
|
||
| stdenv_32bit.mkDerivation { | ||
| name = "loadlibrary"; | ||
| #src = fetchurl { |
| @@ -0,0 +1,30 @@ | |||
| { fetchurl, cabextract, glibc_multi, fetchFromGitHub, readline, stdenv_32bit }: | |||
|
|
|||
| stdenv_32bit.mkDerivation { | |||
There was a problem hiding this comment.
A comment why stdenv_32bit is needed?
There was a problem hiding this comment.
Ok, i ment comment in package, like
# this package requires libc6-i386
| cp mpclient $out/bin/ | ||
| ''; | ||
|
|
||
| meta = with stdenv_32bit.lib; { |
There was a problem hiding this comment.
Just as a note, lib can be imported separately.
proteansec
force-pushed
the
pkgs/loadlibrary
branch
from
016e7e7 to
90a3718
Compare
|
Thanks! Just squash commits, and we are ready to merge :) |
proteansec
force-pushed
the
pkgs/loadlibrary
branch
from
90a3718 to
0d39873
Compare
proteansec
force-pushed
the
pkgs/loadlibrary
branch
from
0d39873 to
d437261
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Addition of loadlibrary to nixpkgs.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)