Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

thunderbird, thunderbird-bin: 52.1.1 -> 52.2.0 [Critical security fixes] #26601

Merged
merged 1 commit into from
Jun 15, 2017
Merged

thunderbird, thunderbird-bin: 52.1.1 -> 52.2.0 [Critical security fixes] #26601

merged 1 commit into from
Jun 15, 2017
+604 −604

Conversation

taku0
Copy link
Contributor

@taku0 taku0 commented Jun 15, 2017

Motivation for this change
  • Critical security fixes
  • Other bug fixes

https://www.mozilla.org/en-US/thunderbird/52.2.0/releasenotes/

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Tested only thunderbird-bin. Compiling thunderbird.

Sorry, something went wrong.

@vcunat
Copy link
Member

vcunat commented Jun 15, 2017

Thank you for all those quick Mozilla updates!

vcunat
vcunat approved these changes Jun 15, 2017
View reviewed changes
Copy link
Member

@vcunat vcunat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to run OK.

vcunat added a commit that referenced this pull request Jun 15, 2017
@vcunat
Merge #26601: thunderbird*: 52.1.1 -> 52.2.0 (security)

Verified

This commit was signed with the committer’s verified signature.
vcunat Vladimír Čunát
GPG key ID: E747DF1F9575A3AA
Verified
Learn about vigilant mode
791f072
@vcunat
Copy link
Member

vcunat commented Jun 15, 2017

Eww, I messed up the history a bit.

@vcunat vcunat merged commit 2732104 into NixOS:master Jun 15, 2017
vcunat added a commit that referenced this pull request Jun 15, 2017
@vcunat
Merge #26601: thunderbird*: 52.1.1 -> 52.2.0 (security)

Verified

This commit was signed with the committer’s verified signature.
vcunat Vladimír Čunát
GPG key ID: E747DF1F9575A3AA
Verified
Learn about vigilant mode
540f8ee 
It's a real *merge* this time, though the changes came in parent.
vcunat added a commit that referenced this pull request Jun 16, 2017
@vcunat
Merge #26601: thunderbird*: 52.1.1 -> 52.2.0 (security)

Verified

This commit was signed with the committer’s verified signature.
vcunat Vladimír Čunát
GPG key ID: E747DF1F9575A3AA
Verified
Learn about vigilant mode
69380c9 
(cherry picked from commit 791f072)
I left out the firefox-bin bits, as they didn't apply anyway.
ambrop72 pushed a commit to ambrop72/nixpkgs that referenced this pull request Jun 21, 2017
@vcunat @ambrop72
Merge NixOS#26601: thunderbird*: 52.1.1 -> 52.2.0 (security)

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Learn about vigilant mode
983c0ed 
(cherry picked from commit 791f072)
I left out the firefox-bin bits, as they didn't apply anyway.
adrianpk added a commit to adrianpk/nixpkgs that referenced this pull request May 31, 2024
@adrianpk
Merge NixOS#26601: thunderbird*: 52.1.1 -> 52.2.0 (security)
c77a251 
(cherry picked from commit 791f072)
I left out the firefox-bin bits, as they didn't apply anyway.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@taku0 @vcunat