Skip to content

ocamlPackages.utop: allow utop to locate topfile #26599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 15, 2017
Merged

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Jun 15, 2017

Motivation for this change

fixes #16085

ping @Zimmi48 @regnat for review.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

--prefix OCAMLPATH ":" $(unset OCAMLPATH; addOCamlPath "$out"; printf %s "$OCAMLPATH")
--prefix OCAMLPATH ":" $(unset OCAMLPATH; addOCamlPath "$out"; printf %s "$OCAMLPATH") \
--add-flags "-I ${findlib}/lib/ocaml/${stdenv.lib.getVersion ocaml}/site-lib"
Copy link
Member Author

@Mic92 Mic92 Jun 15, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please stop me, If I am doing something stupid here. I just started to read real-world ocaml.

@Mic92 Mic92 merged commit 10d0213 into NixOS:master Jun 15, 2017
@thufschmitt
Copy link
Member

I just see this now, but I don't really see the point, as afaik utop directly uses ocamlfind without relying on topfind, and this already works with nix

@Mic92 Mic92 deleted the utop branch April 12, 2018 16:43
@Mic92
Copy link
Member Author

Mic92 commented Apr 12, 2018

I never looked into this again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OCaml findlib doesn't install topfind
2 participants