Firefox #26609
Closed
Firefox #26609
+8
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm, it looks like someone pushed before me. Leaving this PR open, as it cleans up NSS version handling, and also upgrades (I don't get how you got firefox to build without upgrading NSPR, it failed here). |
|
nspr 4.15 is in master; all from the PR #26571 |
|
Uh... what? I was sure I checked on github whether firefox had already been updated before starting to work on this, and this was only ~1hr ago... well, I guess I misread and this PR becomes useless then, thanks! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Update firefox to 54.0. This requires updating nspr and nss too.
I didn't test with nox, given
nix-shell -p noxseems to fail building withAttributeError: '_NamespacePath' object has no attribute 'sort', on my current 0011f90 nixpkgs checkout.firefoxbuilds and runs successfully on my computer after these changes.Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)