ghc821: init at 8.2.1-rc2 (a.k.a., 8.2.0.20170507) #26603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@k0001 Can you port over the cross-compilation stuff from |
|
@shlevy sure, I'll add that as well. Thanks for the quick feedback. |
|
Err the cross compilation stuff in head needs a lot of revamp too. I have a yet-to-be-made PR for that, but it relies on other PRs that still need to be fixed. So yeah, while it's fine to mimick some stuff from ghcHEAD, I'll end up rewriting it all anyways. |
|
@Ericson2314 As long as you update it both here and in HEAD, no need to copy it over for now |
The approach taken to add this package was to port over the definitions currently existing for HEAD, and making the necessesary changes to get this building. The Haskell package set associated with this compiler doesn't yet guarantee that all or most of the packages successfully build with this new compiler, but that will improve over time after this GHC 8.2.1 is officially released and the ecosystem catches up.
|
@shlevy updated. I based my work off |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The approach taken to add this package was to port over the definitions
currently existing for 8.2.0, and making the necessesary changes to get
this building.
The Haskell package set associated with this compiler doesn't yet
guarantee that all or most of the packages successfully build with this
new compiler, but that will improve over time after this GHC 8.2.1
is officially released and the ecosystem catches up.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)