Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Abiword 3.0.2 #26015

Closed
wants to merge 3 commits into from
Closed

Abiword 3.0.2 #26015

wants to merge 3 commits into from

Conversation

armijnhemel
Copy link
Contributor

Motivation for this change

new version, also needs a patch to build properly. Tested on Fedora 25. On my machine the main Abiword screen flickers like crazy though.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@edolstra
Copy link
Member

Wouldn't something like NIX_CFLAGS_COMPILE = "-std=c++11" also work? If they're using nullptr, then we should be compiling in C++11 mode...

@edolstra
Copy link
Member

Did you mean that the flickering occurs in the old or new version?

@armijnhemel
Copy link
Contributor Author

Flickering is in the new version, making it unusable (did not test with the old version). This, however, might have something to do with DRI or something. There are more packages that seem to work fine on NixOS, but not on Fedora when using Nix.

@armijnhemel
Copy link
Contributor Author

will try using the cflags and report back.

@armijnhemel
Copy link
Contributor Author

NIX_CFLAGS_COMPILE seems to work just fine.

@armijnhemel
Copy link
Contributor Author

Any news?

@pSub
Copy link
Member

pSub commented Jul 3, 2017

I wanted to update abiword for a long time. However the flickering is a deal breaker for me. It does not occur with the old version. I'm guessing this problem is due to an interplay of abiword and gtk. However I currently don't have the time to really look into this.

By the way, we are not the only distro having this problem: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=851052

@jtojnar
Copy link
Contributor

jtojnar commented Aug 3, 2017 •
edited

The working area has been turning black or flickering for a long time for me. I think I first noticed it on 3.0 back when I was still running Arch. I can definitely see it on NixOS with 3.0.1.

Edit: The flickering might be a different bug than the black screen, the latter is apparently fixed in 3.0.2.

@globin globin mentioned this pull request Aug 21, 2017
Closed
8 tasks
@jtojnar
Copy link
Contributor

jtojnar commented Nov 25, 2017

Fixed in #31194

@jtojnar jtojnar closed this Nov 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (update)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@armijnhemel @edolstra @pSub @jtojnar