Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expanding on median predictor section #70

Closed
wants to merge 1 commit into from
Closed

expanding on median predictor section #70

wants to merge 1 commit into from

Conversation

dericed
Copy link
Contributor

@dericed dericed commented Jun 7, 2017

No description provided.

@dericed
Copy link
Contributor Author

dericed commented Jun 7, 2017

This moves the context-template into the median prediction section. In the RFC version it auto-adds a Figure # that use the #anchor to make cross-references to, but it's hard to emulate this behavior exactly in the PDF version. Still I think it makes sense for both the median and context sections to use the same figure and relative-sample codes (tl, l, t, etc). I also defined a median function.

Comments?

michaelni
michaelni reviewed Jun 7, 2017
View reviewed changes
ffv1.md Outdated
@@ -111,6 +111,8 @@ log2(a) the base-two logarithm of a

min(a,b) the smallest of two values a and b

median(a,b,c) the numerical middle value in a data set of a, b, and c
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can define median() as a+b+c-min(a,b,c)-max(a,b,c) if you want a more formal definiton without "middle"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated to a mix of the two:

the numerical middle value in a data set of a, b, and c, i.e. a+b+c-min(a,b,c)-max(a,b,c)

@dericed
Copy link
Contributor Author

dericed commented Jun 7, 2017

PR updated according to @michaelni's feedback. Please re-review.

@michaelni michaelni closed this in 0ba8a4c Jun 10, 2017
@JeromeMartinez JeromeMartinez deleted the median-predictor branch June 23, 2020 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelni michaelni michaelni left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dericed @michaelni @retokromer