Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zoom-us: init at 2.0.91373.0502 #26446

Merged
merged 2 commits into from
Jun 7, 2017
Merged

zoom-us: init at 2.0.91373.0502 #26446

merged 2 commits into from
Jun 7, 2017
+94 −0

Conversation

danbst
Copy link
Contributor

@danbst danbst commented Jun 7, 2017

Actually, reintroduce after removal (bb99bab)
and use bundled Qt.

Stepping up as a maintainer

Still, some bugs present (like crash when log-in using Facebook, clear ~/.zoom to recover, bug reported upstream) and I didn't test video (no cam).

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@danbst
zoom-us: init at 2.0.91373.0502
e9da05e 
Actually, reintroduce after removal (NixOS@bb99bab)
and use bundled Qt.
This was referenced Jun 7, 2017
Closed
Closed
@k0001
Copy link
Contributor

k0001 commented Jun 7, 2017 •
edited
Loading

@danbst I just tried this, it's working for me.

I recommend renaming the executable to zoom-us because there already exists another package called zoom exposing an executable called zoom. Moreover, zoom-us was what the executable was called until zoom-us package was removed some weeks ago.

Also, I recommend against just copying all of the top-level contents of the zoom sources to $out/share, since there's a lot of noisy garbage there. Could you create a folder $out/share/zoom-us instead and put all of the files in there?

k0001
k0001 approved these changes Jun 7, 2017
View reviewed changes
Copy link
Contributor

@k0001 k0001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me!

@shlevy
Copy link
Member

shlevy commented Jun 7, 2017

🎊

@shlevy shlevy merged commit 7179b01 into NixOS:master Jun 7, 2017
@kamilchm
Copy link
Member

kamilchm commented Jun 7, 2017

Sign in with Google does nothing for me.
Sign in with SSO ends up with error:

Qt WebEngine resources not found at /home/levi/Qt5.6.2/5.6/gcc_64/resources. Trying parent directory...
Qt WebEngine resources not found at /home/levi/Qt5.6.2/5.6/gcc_64. Trying application directory...
[0607/214354:FATAL:udev_loader.cc(36)] Check failed: false.

@danbst
Copy link
Contributor Author

danbst commented Jun 7, 2017

@kamilchm same for me. :( Let's wait what upstream says about hardcode /home/levi/Qt5.6.2/...

@danbst danbst mentioned this pull request Jun 15, 2017
Merged
7 tasks
@polendri
Copy link
Contributor

polendri commented Sep 8, 2017

👍 Thanks for this, I was 2 hours in to trying to get Zoom running in an Ubuntu VM (crying as my underpowered laptop started compiling VirtualBox in order to use the extension pack for webcam support) before I stumbled upon this, saves me a lot of trouble. nox zoom didn't show me anything, not sure why...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k0001 k0001

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@danbst @k0001 @shlevy @kamilchm @polendri