New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Python 3 from Homebrew for macOS Travis builds #2828
Conversation
.travis.yml
Outdated
- pip3 install virtualenv | ||
- python3 -m virtualenv nikola-tests-venv | ||
- source nikola-tests-venv/bin/activate | ||
- pip install --upgrade pip |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For parity with before_install:
on the linux builds, this last line should probably be:
- pip install --upgrade pip wheel
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, fixed.
@@ -20,13 +20,14 @@ matrix: | |||
include: | |||
- os: osx | |||
language: generic | |||
env: NMODE=nikola | |||
env: NMODE=nikola OS=macOS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The apple vs penguin icons aren't enough?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They’re hard to spot, especially if you’ve never looked there before (and the icons are barely-visible grey)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I asked the question expecting (and largely agreeing with) that answer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
a3c8487
to
8abf6b7
Compare
cc @gwax, @felixfontein — I think this will be better, but feel free to disagree
I’ll merge this if nobody complains by Friday morning (UTC).