buck: init at v2017.05.31.01 #26438
Merged
buck: init at v2017.05.31.01 #26438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mic92
reviewed
Jun 8, 2017
|
|
||
| postPatch = '' | ||
| for f in $(grep -l -r '/bin/bash'); do | ||
| substituteInPlace "$f" --replace '/bin/bash' '${bash}/bin/bash' |
There was a problem hiding this comment.
Do you only replace shebangs here? If so, add bash as buildInput and use patchShebangs . here.
Mic92
reviewed
Jun 8, 2017
| install -D -m755 buck-out/gen/programs/buck.pex $out/bin/buck | ||
| wrapProgram $out/bin/buck \ | ||
| --prefix PYTHONPATH : $PYTHONPATH \ | ||
| --prefix PATH : "${stdenv.lib.makeBinPath [jre watchman]}" |
There was a problem hiding this comment.
It requires java at run-time. Please check that whether jre or jdk is required here.
There was a problem hiding this comment.
jre_headless might be also an option to reduce the closure size.
There was a problem hiding this comment.
buck is primarily used as a Java build tool, so I think it's okay to include JDK.
|
Did you also test to build projects in some languages? Java, C++, Android etc? |
jgertm
commented
Jun 8, 2017
|
|
||
| stdenv.mkDerivation rec { | ||
|
|
||
| let |
There was a problem hiding this comment.
This seems to have no purpose.
|
It builds a really big Clojure codebase, so I think it checks out on that front. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This PR introduces the
buckbuild tool, developed at Facebook. It contains merely the static .pex file generated bybuck build buck, not the recommended mutable directory that buck uses to satisfy the version specified by a project's.buckversionfile.Such is life in Nixistan.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)