chromium: 57.0.2987.133 -> 58.0.3029.110 + build fixes #25940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
somehow, the build seems to have changed with chromium 58, to not auto download the node binary. It is needed to generate webui files and we can substitute our own.
|
If nobody got any better ideas, please get this merged and cherry-pick it to stable as well. We need to keep our users protected. |
|
Merging, given lack of feedback of any kind from maintainers until now. Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Security upgrades.
Things done
Updated versions and fixed the build for linux x86-64
Unfortunately, there were two build breakages from 57 -> 58.
One of them is about the bootstrapped
gn, built during chromium's build. The following patch is needed, until the fix in master has come downstream to stable: bafcf42The other one is about nodejs, which is used during the build to generate stuff. There is a script to download
.../bin/nodebut it doesn't seem to work (anymore ?) in our build. Failing to get a response from chromium devs, I just tried softlinking our node binary into the build tree and it actually works: 1fe7bd9There are two open issues with this, though:
cc @aszlig
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)