Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract OpenSSL::Error to separate source file, document it #4435

Closed
wants to merge 2 commits into from
Closed

Extract OpenSSL::Error to separate source file, document it #4435

wants to merge 2 commits into from

Conversation

akzhan
Copy link
Contributor

@akzhan akzhan commented May 20, 2017

and reorder requires in source files of openssl just to allow
syntax check on the fly in editor.

@akzhan
Extract OpenSSL::Error to separate source file, document it
2da16f4 
and reorder requires in source files of openssl just to allow
syntax check on the fly in editor.
@akzhan
We need openssl/error at top on openssl.
26c5865
@RX14
Copy link
Contributor

RX14 commented May 26, 2017

Is there a reason why you extracted OpenSSL::Error into a new file instead of leaving it in-place?

@akzhan
Copy link
Contributor Author

akzhan commented May 26, 2017 •
edited

Yes, the reason is the ability to check any file in the src/openssl directory for syntax errors on the fly. It is convenient for development and is supported usually out of the box by the IDEs/plugins.

And there are no reasons to keep it in src/openssl.cr

@straight-shoota
Copy link
Member

straight-shoota commented Feb 16, 2020 •
edited

Closing for now activity in 2,5 years. OpenSSL is supposed to be refactored anyway at which point this will be addressed.

Thank you @akzhan anyway

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
kind:refactor topic:stdlib
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@akzhan @RX14 @straight-shoota @mverzilli