stdenv: Rename isGNU to isHurd as GNU is a userland
#25997
Merged
+54
−65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Elsewhere, things called GNU indeed includes GNU/Linux or GNU/Hurd, but this predicate was defined excluding Linux regardless of userland.
| isArm = hostPlatform.isArm32; | ||
| isAarch64 = hostPlatform.isArm64; | ||
| # Other code instead checks for anything using GNU userland, | ||
| # e.g. GNU/linux. This refers just to GNU Hurd. | ||
| isGNU = system == "i686-gnu"; |
There was a problem hiding this comment.
There might be a few references to this you missed:
nixpkgs/pkgs/development/tools/misc/gdb/default.nix
Lines 20 to 22 in 9d5c28d
- `isGNU` to `isHurd`, my sedding did not catch - Simplify cross compilation in general - Be more careful about python - no more `gdbCross` in all-packages
matthewbauer
approved these changes
May 22, 2017
- Simplified platform-specific options - Almost ready for cross-compilation
|
Travis is borked from some big rebuild, so merging. I ran the travis stuff locally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Elsewhere, things called GNU indeed includes GNU/Linux or GNU/Hurd, but this predicate was defined excluding Linux regardless of userland.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)CC @matthewbauer (it won't let me request a review)