@disassembler, thanks for your PR! By analyzing the history of the files in this pull request, we identified @fpletz, @teh and @offlinehacker to be potential reviewers.

Thanks!

Not that it's too important, but I'm curious how this fixes anything? [ "x" = "y" ] is perfectly valid (a single = is the string equality operator understood by test), whereas [ "x" == "y" ] seems to be a bashism (breaks on ash and zsh).

Yes, please don't use unnecessary bashisms.

Oops, sorry, wasn't aware of that. Will revert after more feedback.

@disassembler What was the exact problem you were trying to solve? In what context did the the single = not work for you?

Afaik, the point of == is to perform pattern matching, but it's an extended syntax as far as traditional test is concerned. I suspect Bash is being helpful by supporting the extended syntax in its test builtin.

After some reading I found that the bash manpage states:

When the == and != operators are used, the string to the right of the operator is considered a pattern […]. The = operator is equivalent to ==.

And test indeed only supports = for string matching. So I'll revert for now. Thanks for the explanation.

The joys of shell programming :)

sorry for the confusion. Learned something new. I'll update my preStart script as well in the module I'm working on.