ghc: 8.0.2 without link warnings #25998
Merged
+26
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes NixOS#25139 by backporting patch applied in ghc trunk: https://phabricator.haskell.org/D2823
|
cc @peti |
peti
requested changes
Jun 11, 2017
There was a problem hiding this comment.
Is it possible to download that patch from somewhere, like the GHC git repository, instead of checking it into our repository?
If that is not possible, can you please call that patch file "ghc-8.0.2-no-cpp...patch" or something like that to make it obvious that it applies only to one particular version of GHC?
|
@peti It's not possible to download that patch from anywhere because it's a backport of a patch (git commit) applied to a later version of the GHC. I renamed the patch file to indicate that it only applies to 8.0.2 |
peti
approved these changes
Jun 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Fixes #25139 by backporting patch applied in ghc trunk:
https://phabricator.haskell.org/D2823
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)