Update and improve support for CD Baby URLs (MBS-9311, MBS-9348) #513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
with auto-select, clean-up, and validation of `http://www.cdbaby.com/Artist/\w+` URLs.
Previously, only `cdbaby.com` and `www.cdbaby.com` URLs were displayed as CD Baby URLs in the sidebar. This patch additionally displays `store.cdbaby.com` URLs. It keeps ignoring `images.cdbaby.com` and `members.cdbaby.com`.
Previously, both `cdbaby.com` and `www.cdbaby.com` were recognized and URLs were normalized to start with `http://www.cdbaby.com`. This patch adds recognition of `store.cdbaby.com` URLs, normalizes URLs to start with `https://store.cdbaby.com` and validates URLs that follow this new pattern only. It keeps converting `images.cdbaby.com` URLs when it is possible.
|
Test failures are unrelated to code changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://store.cdbaby.com(MBS-9348)