Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libvirtd: remove onShutdown option #26008

Closed

Conversation

Profpatsch
Copy link
Member

It hasn’t been influencing the module implementation for a long time.

cc @fpletz

It hasn’t been influencing the module implementation for a long time.
@mention-bot
Copy link

@Profpatsch, thanks for your PR! By analyzing the history of the files in this pull request, we identified @edolstra, @bjornfor and @rickynils to be potential reviewers.

@fpletz
Copy link
Member

fpletz commented May 24, 2017

Thanks for noticing that. It might make sense to implement this, though. :) I have some bugfixes for the module coming up anyway due to (not configurable) VM suspend on host shutdown.

The problem is that on suspend, libvirtd saves the full path to the qemu exectuable in the nix store with which the VM was initially started. On host boot, this store path might have been garbage collected already i.e. if the VM has already been running since a few host system generations.

@fpletz fpletz self-assigned this May 24, 2017
@mattywillo
Copy link

Is there any movement on this front? Looks like onShutdown still does nothing. I'm in favor of it being implemented, but barring that it may be best to remove it for now, as it's pretty misleading.

@Profpatsch
Copy link
Member Author

#49480 fixes this by actually using the option.

@Profpatsch Profpatsch closed this Jan 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants