Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

utillinux: fix "fstrim --all" #26540

Merged
merged 1 commit into from Jun 16, 2017
Merged

utillinux: fix "fstrim --all" #26540

merged 1 commit into from Jun 16, 2017

Conversation

ghost
Copy link

@ghost ghost commented Jun 12, 2017 •
edited by ghost

Motivation for this change

Apply patch from upstream that for NixOS fixes fstrim -a and fstrim service. See patch description for details https://git.kernel.org/pub/scm/utils/util-linux/util-linux.git/patch/?id=155d48f590a50bb5dc265162ff2f9a971daed543

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@gnidorah, thanks for your PR! By analyzing the history of the files in this pull request, we identified @dezgeg, @edolstra and @vcunat to be potential reviewers.

@ghost ghost mentioned this pull request Jun 12, 2017
Closed
7 tasks
@ghost ghost changed the title utillinux: fix all mounted fstrim mode utillinux: fix "fstrim --all" Jun 13, 2017
@Mic92
Copy link
Member

Mic92 commented Jun 13, 2017 •
edited

Can you also send this patch to http://vger.kernel.org/vger-lists.html#util-linux ?

@ghost
Copy link
Author

ghost commented Jun 15, 2017

@Mic92 Done, thanks! Upstream accepted it.

@Mic92
Copy link
Member

Mic92 commented Jun 16, 2017

@vcunat should util-linux go to staging first?

@ghost
Copy link
Author

ghost commented Jun 16, 2017 •
edited by ghost

@Mic92 Suppose it should. My previous PR touching utillinux went through staging #26205 (comment)

@vcunat vcunat changed the base branch from master to staging-17.03 June 16, 2017 19:41
@vcunat vcunat changed the base branch from staging-17.03 to staging June 16, 2017 19:42
@vcunat vcunat self-assigned this Jun 16, 2017
@vcunat vcunat merged commit 286c36d into NixOS:staging Jun 16, 2017
vcunat added a commit that referenced this pull request Jun 16, 2017
@vcunat
Merge #26540: utillinux: fix "fstrim --all"
2a76b6a
@vcunat
Copy link
Member

vcunat commented Jun 16, 2017 •
edited

Seems OK It is a relatively large rebuild (>5k just on x86_64-linux), so I staged it.

@ghost
Copy link
Author

ghost commented Jun 16, 2017

@vcunat Thank you!

@ghost ghost deleted the master2 branch June 16, 2017 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@vcunat vcunat

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mention-bot @Mic92 @vcunat