Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zabbix-cli: init at 1.6.1 #26121

Merged
merged 1 commit into from
Jul 5, 2017
Merged

zabbix-cli: init at 1.6.1 #26121

merged 1 commit into from
Jul 5, 2017

Conversation

womfoo
Copy link
Member

@womfoo womfoo commented May 26, 2017

  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

0xABAB
0xABAB reviewed Jun 26, 2017
View reviewed changes
Copy link
Contributor

@0xABAB 0xABAB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove some superfluous newlines (e.g., line 4) and inconsistent spaces (e.g. on line 1).

@womfoo
Copy link
Member Author

womfoo commented Jun 27, 2017

Done weeding out whitespaces. I'm assuming you meant inconsistent sorting for line 1 so I fixed that too.

@7c6f434c 7c6f434c merged commit c089080 into NixOS:master Jul 5, 2017
@womfoo womfoo deleted the init/zabbix-cli-1.6.1 branch July 6, 2017 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xABAB 0xABAB 0xABAB approved these changes

Assignees
No one assigned
Labels
8.has: package (new)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@womfoo @0xABAB @pSub @7c6f434c