cloudmonkey: init at 5.3.3 with related dependency argcomplete: init at 1.8.2 #26124
Conversation
pkgs/top-level/python-packages.nix
Outdated
| @@ -1159,6 +1159,28 @@ in { | |||
| }; | |||
| }; | |||
|
|
|||
| argcomplete = buildPythonPackage rec { | |||
There was a problem hiding this comment.
Python modules have to be in the directory pkgs/development/python-modules/ as suggested here.
There was a problem hiding this comment.
Thanks! It's been a while since I last contributed a python library. Just pushed a new commit for this.
| @@ -0,0 +1,25 @@ | |||
| { python2Packages, lib }: | |||
There was a problem hiding this comment.
FYI, it seems no tests are executed.
There was a problem hiding this comment.
I'm mostly a python user rather than a developer and couldn't find where to enable the tests for cloudmonkey (nothing in the repo or its setup.py). Any pointers?
There was a problem hiding this comment.
Yep, I'm also not able to find any tests;)
There was a problem hiding this comment.
if there are no tests, add doCheck = false; and include a comment explaining why they're disabled
womfoo
force-pushed
the
init/cloudmonkey-5.3.3
branch
from
37d35f8 to
4be0d8b
Compare
| @@ -0,0 +1,25 @@ | |||
| { python2Packages, lib }: | |||
There was a problem hiding this comment.
Yep, I'm also not able to find any tests;)
| meta = with lib; { | ||
| description = "Bash tab completion for argparse"; | ||
| homepage = "https://argcomplete.readthedocs.io"; | ||
| maintainers = maintainers.womfoo; |
womfoo
force-pushed
the
init/cloudmonkey-5.3.3
branch
2 times, most recently
from
2a56d5d to
26240e2
Compare
|
|
||
| doCheck = false; # bash-completion test fails with "compgen: command not found". | ||
|
|
||
| propagatedBuildInputs = [ coverage dicttoxml flake8 pexpect prettytable requests_toolbelt ]; |
There was a problem hiding this comment.
are all of these runtime dependencies? To me, it seems like some (like flake8) are only needed for tests
There was a problem hiding this comment.
You're right, now moved coverage and flake8 to a commented buildInputs while tests are disabled. I've also manually tested the package and it works fine.
womfoo
force-pushed
the
init/cloudmonkey-5.3.3
branch
from
26240e2 to
cf14cf3
Compare
womfoo
force-pushed
the
init/cloudmonkey-5.3.3
branch
from
cf14cf3 to
4126cc1
Compare
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)