Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qt5ct: 0.30 -> 0.32 #26120

Merged
merged 1 commit into from Jun 2, 2017
Merged

qt5ct: 0.30 -> 0.32 #26120

merged 1 commit into from Jun 2, 2017

Conversation

romildo
Copy link
Contributor

@romildo romildo commented May 26, 2017

Motivation for this change

Changelogs

0.32 12 days ago

  • added global menu support
  • updated Czech translation
  • updated Greek translation
  • updated Russian translation

0.31 1 month ago

  • added option "Toolbar button style"
  • added option "Mouse wheel scroll lines"
  • added test for minimal Qt version
  • added Arabic translation
  • using c++11 for source code
  • fixed Qt 5.4 support
  • updated Russian translation
  • updated Bulgarian translation
  • updated Dutch (Netherlands) translation
  • updated Chinese (Taiwan) translation
  • updated German translation
  • updated Serbian translation
  • updated Czech translation
Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@romildo, thanks for your PR! By analyzing the history of the files in this pull request, we identified @Ralith to be a potential reviewer.

Ralith
Ralith reviewed May 27, 2017
View reviewed changes
pkgs/tools/misc/qt5ct/default.nix Outdated

preFixup = ''
wrapQtProgram $out/bin/qt5ct
'';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why were these removed?

Copy link
Contributor Author

@romildo romildo May 27, 2017 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed those lines after verifying that the application works without them.

But I am going to restore those lines. Some files are not installed without the plugin dir setup.

Sorry for the inconvenience.

Ralith
Ralith approved these changes May 30, 2017
View reviewed changes
Copy link
Contributor

@Ralith Ralith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't been able to test this locally, but it's a trivial version bump and it builds.

@ttuegel ttuegel merged commit b0da92d into NixOS:master Jun 2, 2017
@romildo romildo deleted the upd.qt5ct branch June 2, 2017 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ralith Ralith Ralith approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@romildo @mention-bot @Ralith @ttuegel