lldb: fix on Darwin #26112
Merged
lldb: fix on Darwin #26112
+6
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@matthewbauer, thanks for your PR! By analyzing the history of the files in this pull request, we identified @dtzWill to be a potential reviewer. |
|
Does this work when combined with #26099? Would expect so but just wanted to check :). Regardless, LGTM. |
|
i'll look into it and maybe even rebase onto to avoid merge conflicts |
matthewbauer
force-pushed
the
lldb-darwin
branch
2 times, most recently
from
11c77ce to
1e0db88
Compare
|
@dtzWill Seems to work fine! I've rebased on your PR so make sure to wait until it merges before you merge this PR. |
|
@matthewbauer can you rebase again |
matthewbauer
force-pushed
the
lldb-darwin
branch
3 times, most recently
from
144b90d to
bd01d5e
Compare
This gives a few fixes for LLDB on Darwin. Note: you will have to do code signing for it to work outside of root!
|
Got it |
LnL7
approved these changes
Jun 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gives a few fixes for LLDB on Darwin.
Note: you will have to do code signing for it to work outside of root!
Motivation for this change
LLDB was not supporting Darwin for some reason. This should make things work fine. Codesigning is of course not doable currently.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)