darwin-stdenv: remove python dependencies #26310
Conversation
LnL7
added
1.severity: mass-darwin-rebuild
|
/cc @vcunat It's not ideal, but this reduces the stdenv packages back to what most people will expect. |
|
@LnL7 would it be possible to save the build directory to an output and then build the docs from that? That way, you could have the docs without a full rebuild and without making it a requirement of the stdenv. |
|
I was thinking of fixing it in the bootstrap stages, but that could also work. Either way I'd like to get this in master first to avoid unexpected rebuilds. |
| @@ -45,7 +49,8 @@ let | |||
| sed -i '1s,^,find_package(Sphinx REQUIRED)\n,' docs/CMakeLists.txt | |||
| ''; | |||
|
|
|||
| outputs = [ "out" "man" "python" ]; | |||
| outputs = [ "out" "python" ] | |||
| ++ stdenv.lib.optional enableManpages "man"; | |||
There was a problem hiding this comment.
I think this is going to cause a linux mass-rebuild as well, because the order of the outputs has changed.
There was a problem hiding this comment.
yes, the second commit introduces rebuilds. this is not the only thing
| outputs = [ "out" "man" ] ++ stdenv.lib.optional enableSharedLibraries "lib"; | ||
| outputs = [ "out" ] | ||
| ++ stdenv.lib.optional enableSharedLibraries "lib" | ||
| ++ stdenv.lib.optional enableManpages "man"; |
|
I just wanted to wait for hydra to get through the large trunk/staging queue first. |
|
I only skimmed it very briefly. My knowledge of Darwin (and interest) is rather low. |
Motivation for this change
Disable the llvm/clang manpages on darwin to avoid python packages in the stdenv. 😞
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)