Wrap gnome control center and online accounts #26305
Merged
+7
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
selaux
changed the title
bjornfor
reviewed
Jun 3, 2017
| --set GDK_PIXBUF_MODULE_FILE "$GDK_PIXBUF_MODULE_FILE" \ | ||
| --prefix XDG_DATA_DIRS : "${gnome3.gnome_themes_standard}/share:${sound-theme-freedesktop}/share:$out/share:$out/share/gnome-control-center:$XDG_ICON_DIRS:$GSETTINGS_SCHEMAS_PATH" | ||
| for i in $out/share/applications/*; do | ||
| substituteInPlace $i --replace "gnome-control-center" "$out/bin/gnome-control-center" |
There was a problem hiding this comment.
Did you check that this substituteInPlace line is not needed anymore?
There was a problem hiding this comment.
Thanks for spotting, that was still needed. I added it back.
|
Any chance for a merge? |
selaux
force-pushed
the
wrap-gnome-things
branch
from
019b8df to
9e80d36
Compare
selaux
force-pushed
the
wrap-gnome-things
branch
from
9e80d36 to
0340a33
Compare
0xABAB
approved these changes
Jul 1, 2017
|
Thanks! |
selaux
force-pushed
the
wrap-gnome-things
branch
from
0340a33 to
845a403
Compare
|
Rebased. |
bjornfor
added
the
6.topic: GNOME
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
I could not add an exchange account using
gnome-online-accountsbecause it could not findglib_networkingThings done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)