Integrate spmd multidimensionnal views for partitioned_vectors #2670
Conversation
atrantan
force-pushed
the
partitioned_vector_view
branch
4 times, most recently
from
77e0c56
to
dc5d5ed
Compare
|
Inspect is unhappy with this: https://6936-4455628-gh.circle-artifacts.com/0/tmp/circle-artifacts.tnk4CwV/hpx_inspect_report.html |
atrantan
force-pushed
the
partitioned_vector_view
branch
3 times, most recently
from
ce61e50
to
1682d5c
Compare
| @@ -0,0 +1,113 @@ | |||
| // Copyright (c) 2017 Antoine Tran Tan | |||
There was a problem hiding this comment.
This is a duplication of code that can be found here:
https://github.com/STEllAR-GROUP/hpx/blob/master/hpx/util/detail/pack.hpp#L44
There was a problem hiding this comment.
@sithhell I know. The reason is that multidimensionnal view usually does not exceed dimension 3 or 4 in scientific domains. The unrolled version implemented here (for those cases) has a much faster compilation time.
There was a problem hiding this comment.
Wouldn't it be better then to add the unrolled version to pack.hpp instead, so the whole library profits from it?
|
Documentation is in progress. But I need some documentation for
|
|
Sorry, but I'm not Sithhel, I'm Sithell
|
atrantan
force-pushed
the
partitioned_vector_view
branch
from
1682d5c
to
fbb2659
Compare
|
Oh, guys, I'm not your teammate. I'm Sithell, not Sithhel.
Stop sending me emails, please
|
Sorry for that again :/ Can't guarantee it will not happen again, though ;) |
|
Wouldn't it be better then to add the unrolled version to pack.hpp instead, so the whole library profits from it?
I agree, this should have been done instead.
|
|
@atrantan: could you prepare a separate PR please which integrates your unrolled implementation with the existing code in |
This PR proposes to add spmd multidimensionnal view functionalities to manage segments of
partitioned_vector. The added features include:partitioned_vectoriterators :example:
hpx::partitioned_vector_view<double,2> view (block, v.begin(), v.end(), {height,width} ), withblockbeing aspmd_block,vbeing apartitioned_vectorand height and width being integral valuesa(i,j) = b(i,j)ora(i,j) = some_std_vectorstd::vector<T> v = ( std::vector<T> ) a(i,j)