-
-
Notifications
You must be signed in to change notification settings - Fork 15.5k
Add/resilio sync #26303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add/resilio sync #26303
Conversation
I am ok with porting this release-17.03 (as the old service might stop working). However we have the policy to first merge to master and then cherry pick the commits back to the release branch. This particular pull request looks simple enough, that I can do the rebasing and merging in the right order. |
Thanks @Mic92 - I think I missed the last point of the "Making Patches" section (could've sworn I got all of them...). I'll do better next time. |
Did you test the service before hand? It contained some evaluation errors. You can test services as described here: https://github.com/nixos-users/wiki/wiki/nix-command-cookbook#build-nixos-from-nixpkgs-repo Nevertheless, I made it work on master. Can you confirm whether it also works on 17.03? |
@Mic92 Have tested with |
this used to be part of the upstream btsync package
in other btsync package was an systemd user service, which was overridden in the nixos module. Since this is no longer the case with resilio-sync, I dropped it. |
this used to be part of the upstream btsync package fixes NixOS#26303 (cherry picked from commit 3d17573)
Motivation for this change
The btsync service and package are no longer supported upstream, and should be replaced by the resilio sync service and package (see issue #19436).
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandbox
innix.conf
on non-NixOS)
nix-shell -p nox --run "nox-review wip"
./result/bin/
)(my apologies for the previous pull request against the incorrect branch!)